[AMD] Always swap operands of mfma and use mfma.transposed layout #4767
+39
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zhanglx13
commented
Sep 20, 2024
•
zhanglx13
commented
- Fixed the issue with getOrder for mfma layout
- Fixed the issue with reduceOp when dealing with mfma.transposed layout
Also fixed the issue with getOrder for mfma layout
In general, we should use getThreadOrder in most places where getOrder is called. Note that order and threadOrder can be different, and this is the case for mfma.transposed layout.
zhanglx13
force-pushed
the
fix_order_mfma_transposed
branch
from
2065595
to
c525ee0
Compare
antiagainst
requested changes
Sep 20, 2024
| @@ -79,6 +79,8 @@ SmallVector<unsigned> getWarpOrder(Attribute layout); | |||
|
|
|||
| SmallVector<unsigned> getOrder(Attribute layout); | |||
|
|
|||
| SmallVector<unsigned> getThreadOrder(Attribute layout); | |||
There was a problem hiding this comment.
Add some doc to both this one and the above getOrder so that it's easier to know the difference?
| mfmaEnc = ttg::AMDMfmaEncodingAttr::get( | ||
| oldRetType.getContext(), | ||
| /*versionMajor*/ mfmaVersion, /*versionMinor*/ 0, warpsPerTile, | ||
| /*instrShape*/ mDim, nDim, isTransposed, CTALayout); | ||
| /*instrShape*/ mDim, nDim, /*isTransposed*/ true, CTALayout); |
There was a problem hiding this comment.
Can you add some comments in the above of why we want to always set it as transposed? It makes it easier to follow for others reading the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.